Skip to content

CompatHelper: add new compat entry for MCMCChains at version 7 for package test, (keep existing compat)#2824

Merged
sunxd3 merged 3 commits into
mainfrom
compathelper/new_version/2026-05-03-01-10-04-548-02911131135
May 14, 2026
Merged

CompatHelper: add new compat entry for MCMCChains at version 7 for package test, (keep existing compat)#2824
sunxd3 merged 3 commits into
mainfrom
compathelper/new_version/2026-05-03-01-10-04-548-02911131135

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 3, 2026

This pull request sets the compat entry for the MCMCChains package to 7 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@penelopeysm penelopeysm force-pushed the compathelper/new_version/2026-05-03-01-10-04-548-02911131135 branch from d05e454 to 95ff2a1 Compare May 3, 2026 01:10
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented May 3, 2026

Turing.jl documentation for PR #2824 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2824/

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.07%. Comparing base (18eedab) to head (240aa20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2824      +/-   ##
==========================================
+ Coverage   84.61%   85.07%   +0.46%     
==========================================
  Files          23       23              
  Lines        1514     1514              
==========================================
+ Hits         1281     1288       +7     
+ Misses        233      226       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yebai yebai requested a review from shravanngoswamii May 12, 2026 16:42
@shravanngoswamii
Copy link
Copy Markdown
Member

@yebai I am happy to merge this, but how long are we planning to keep MCMCChains around in the ecosystem? Many people might still be using it, but maybe we should start phasing it out. And we should start improving guidance for users toward FlexiChains -- which I suppose is already ongoing.

@yebai
Copy link
Copy Markdown
Member

yebai commented May 13, 2026

@shravanngoswamii, happy for you to figure out a sensible plan for it -- FlexiChains is still new and likely requires time to mature/improve.

@shravanngoswamii shravanngoswamii self-assigned this May 13, 2026
Copy link
Copy Markdown
Member

@shravanngoswamii shravanngoswamii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self reviewed my changes in this PR

Comment thread Project.toml
Comment thread ext/TuringMCMCChainsExt.jl
Comment thread test/mcmc/chains.jl
@shravanngoswamii
Copy link
Copy Markdown
Member

shravanngoswamii commented May 13, 2026

happy for you to figure out a sensible plan for it

Looking at FlexiChains -- it still needs some work on visualization's support, and once FlexiChains has reasonable parity and we can add a soft deprecation notice, like maybe print a one-time @info when chain_type=MCMCChains.Chains is used.

@shravanngoswamii
Copy link
Copy Markdown
Member

shravanngoswamii commented May 14, 2026

@yebai Is it fine if I merge these kinds of PRs without 2nd reviews?

@yebai
Copy link
Copy Markdown
Member

yebai commented May 14, 2026

Thanks @shravanngoswamii!

@sunxd3
Copy link
Copy Markdown
Member

sunxd3 commented May 14, 2026

happy to review these PRs if you need a second opinion

@shravanngoswamii
Copy link
Copy Markdown
Member

shravanngoswamii commented May 14, 2026

Thanks @sunxd3, will ping you whenever I update them!

Feel free to merge this one!

@sunxd3 sunxd3 added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 66532f4 May 14, 2026
53 of 54 checks passed
@sunxd3 sunxd3 deleted the compathelper/new_version/2026-05-03-01-10-04-548-02911131135 branch May 14, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants